lx: fix transport padding buffer overrun + harden AWG config guards

Transport padding (s4) crashed the whole process with
"index out of range" in RoutineSequentialSender on the first data
packet: InputPacket/InputPackets sized elem.buffer without headroom
for the in-buffer right-shift that prepends the random prefix.

- send.go: reserve paddings.transport in both injection-path
  allocLength computations; replace the manual backward byte loop
  with an overlap-safe copy; defensively grow the buffer (pool-backed)
  if it still lacks headroom, dropping packets that cannot fit a
  single WG message instead of overrunning.
- receive.go: drop the rxBytes/timers block duplicated by the AWG
  re-graft (rx accounting was doubled, keepKeyFreshReceiving fired
  twice per batch).
- send.go: swap jmin/jmax when configured inverted (UAPI validates
  the fields only individually; a swapped pair panicked rand.Int
  with a non-positive bound on the first handshake).
- obf*.go: bound obfuscator length args to [0, MaxMessageSize]
  (negative panicked slice bounds, huge ones OOMed the handshake).
- magic-header.go: widen to int64 before end-start+1 so a full-range
  header cannot wrap to a zero rand.Int bound.

Tests: transport_padding_test.go reproduces the on-device crash
byte-for-byte (red on the previous commit, green now) across both
injection paths and the tun path; obf_guards_test.go pins the
config-value guards.
This commit is contained in:
Leadaxe 2026-07-16 12:45:56 +03:00
parent 831d483366
commit ee7ff1b77f
9 changed files with 502 additions and 12 deletions

View file

@ -3,11 +3,26 @@ package device
import (
"errors"
"fmt"
"strconv"
"strings"
)
type obfBuilder func(val string) (obf, error)
// parseObfLen parses and bounds an obfuscator length argument: a negative
// value would panic slice bounds in obfChain.Obfuscate, a huge one would
// OOM in the handshake-time make (SendHandshakeInitiation).
func parseObfLen(val string) (int, error) {
length, err := strconv.Atoi(val)
if err != nil {
return 0, err
}
if length < 0 || length > MaxMessageSize {
return 0, fmt.Errorf("obfuscator length %d out of range [0, %d]", length, MaxMessageSize)
}
return length, nil
}
var obfBuilders = map[string]obfBuilder{
"b": newBytesObf,
"t": newTimestampObf,